Merge of r4473:
Core: protection from cycles with named locations and post_action.
Now redirects to named locations are counted against normal uri changes
limit, and post_action respects this limit as well. As a result at least
the following (bad) configurations no longer trigger infinite cycles:
1. Post action which recursively triggers post action:
location / {
post_action /index.html;
}
2. Post action pointing to nonexistent named location:
location / {
post_action @nonexistent;
}
3. Recursive error page for 500 (Internal Server Error) pointing to
a nonexistent named location:
location / {
recursive_error_pages on;
error_page 500 @nonexistent;
return 500;
}
Maxim Dounin
8 years ago
| 2523 | 2523 | ngx_http_core_main_conf_t *cmcf; |
| 2524 | 2524 | |
| 2525 | 2525 | r->main->count++; |
| 2526 | r->uri_changes--; | |
| 2527 | ||
| 2528 | if (r->uri_changes == 0) { | |
| 2529 | ngx_log_error(NGX_LOG_ERR, r->connection->log, 0, | |
| 2530 | "rewrite or internal redirection cycle " | |
| 2531 | "while redirect to named location \"%V\"", name); | |
| 2532 | ||
| 2533 | ngx_http_finalize_request(r, NGX_HTTP_INTERNAL_SERVER_ERROR); | |
| 2534 | return NGX_DONE; | |
| 2535 | } | |
| 2526 | 2536 | |
| 2527 | 2537 | cscf = ngx_http_get_module_srv_conf(r, ngx_http_core_module); |
| 2528 | 2538 |